Merged
Conversation
Reviewer's GuideThis PR migrates the LSAAI integration by replacing all occurrences of the old Elixir-Czech AAI domain with the new LifeScience-RI AAI domain in the React frontend’s OAuth flows. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @trispera - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Testing: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| const handleLogout = async () => { | ||
| const params = JSON.parse(localStorage.getItem(AUTH_TOKEN) || '{}'); | ||
| localStorage.removeItem(AUTH_TOKEN); | ||
| window.location.href = `https://login.elixir-czech.org/oidc/endsession?id_token_hint=${params.id_token}&post_logout_redirect_uri=${HOST_URI}`; |
There was a problem hiding this comment.
issue: Handle missing or invalid id_token_hint
Check that params.id_token is defined before appending it; otherwise a missing or malformed AUTH_TOKEN yields an undefined id_token_hint and breaks the logout URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMPORTANT: Please create an issue before filing a pull request! Changes need to be discussed before proceeding. Please read the contribution guidelines.
Details
Update LSAAI URL. From
https://login.elixir-czech.orgtohttps://login.aai.lifescience-ri.euTesting
Rebuild in Rahti. Accessible here: https://elixir-krini-devel.2.rahtiapp.fi/login
Summary by Sourcery
Update LSAAI OIDC endpoints to the new domain across login, logout, and userinfo requests
Enhancements: